Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precalculate resistance neighbors #1436

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Precalculate resistance neighbors #1436

merged 2 commits into from
Apr 29, 2024

Conversation

visr
Copy link
Member

@visr visr commented Apr 29, 2024

On top of #1435.
This significantly speeds up the running time at the cost of using slightly more storage.

@visr visr added the performance Relates to runtime performance or convergence label Apr 29, 2024
Copy link
Collaborator

@SouthEndMusic SouthEndMusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, also some improved docstrings 👍

@visr visr merged commit 40cf6fa into main Apr 29, 2024
24 checks passed
@visr visr deleted the resistance-id branch April 29, 2024 09:51
visr added a commit that referenced this pull request Apr 29, 2024
Like #1436, but for Basin. Those have `n` inflow and `n` outflow nodes,
so I'm using a Vector of Vectors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Relates to runtime performance or convergence
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants